[WIP] Move robot-common part of simulated grasping to robot-interface#435
Open
pazeshun wants to merge 2 commits intojsk-ros-pkg:masterfrom
Open
[WIP] Move robot-common part of simulated grasping to robot-interface#435pazeshun wants to merge 2 commits intojsk-ros-pkg:masterfrom
pazeshun wants to merge 2 commits intojsk-ros-pkg:masterfrom
Conversation
pazeshun
force-pushed
the
move-common-sim-grasp
branch
from
87deb4e to
8a4e557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
:start-graspand:stop-graspof pr2-interface, object assoc/dissoc for Kinematics Simulator doesn't seem robot-specific.So this PR moves those parts to robot-interface as
:assoc-objects-in-gripperand:dissoc-objects-in-gripper.Currently, not tested well.