Generalize :wait-interpolation-smooth#356
Open
pazeshun wants to merge 5 commits intojsk-ros-pkg:masterfrom
Open
Generalize :wait-interpolation-smooth#356pazeshun wants to merge 5 commits intojsk-ros-pkg:masterfrom
pazeshun wants to merge 5 commits intojsk-ros-pkg:masterfrom
Conversation
Collaborator
Author
|
Tested with...
|
…rollers on real robot
c21f49a to
6086658
Compare
k-okada
approved these changes
Jul 24, 2018
Member
|
Could you test with HRP2 or other robot using hrpsys-base? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
:wait-interpolation-smoothto support all cases in start-jsk/rtmros_common#1052 (comment)time_from_startof feedback because this value varies by robotFix
:wait-interpolation-smoothto work in kinematics simulator of roseus.:wait-interpolation-smoothin simulator exits immediately after called.(Minor Fix) Fix return value of
:wait-interpolation-smoothto the same as:wait-interpolation:wait-interpolation-smoothreturns nil