Skip to content

Generalize :wait-interpolation-smooth#356

Open
pazeshun wants to merge 5 commits intojsk-ros-pkg:masterfrom
pazeshun:generalize-wait-interpolation-smooth
Open

Generalize :wait-interpolation-smooth#356
pazeshun wants to merge 5 commits intojsk-ros-pkg:masterfrom
pazeshun:generalize-wait-interpolation-smooth

Conversation

@pazeshun
Copy link
Copy Markdown
Collaborator

@pazeshun pazeshun commented Jul 13, 2018

Enable :wait-interpolation-smooth to support all cases in start-jsk/rtmros_common#1052 (comment)

  • Exit from the method at the correct timing even if feedback from joint trajectory action is not published
  • Don't relay on time_from_start of feedback because this value varies by robot

Fix :wait-interpolation-smooth to work in kinematics simulator of roseus.

  • Without this PR, :wait-interpolation-smooth in simulator exits immediately after called.

(Minor Fix) Fix return value of :wait-interpolation-smooth to the same as :wait-interpolation

  • Return value is a list of interpolatingp for all controllers
    • The list may include t because interpolation may not finish
  • Fix test to follow this change because test assumed :wait-interpolation-smooth returns nil

@pazeshun
Copy link
Copy Markdown
Collaborator Author

Tested with...

  • PR2
  • Baxter (with gripper)
  • Fetch
  • HIRONX (simulation)

@pazeshun pazeshun force-pushed the generalize-wait-interpolation-smooth branch from c21f49a to 6086658 Compare July 14, 2018 03:48
@pazeshun pazeshun self-assigned this Jul 24, 2018
@mmurooka
Copy link
Copy Markdown
Member

Could you test with HRP2 or other robot using hrpsys-base?
https://github.com/start-jsk/rtmros_hrp2/blob/master/README.md is manual to use HRP2 simulator and real robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants