dtls13: preserve app data after same-datagram KeyUpdate#122
Draft
zRedShift wants to merge 2 commits into
Draft
Conversation
90989cf to
a2ad7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft stacked on #121. Once #121 lands, this PR should be rebased onto
mainand its diff should collapse to the single DIMP-015 commit.What
This preserves DTLS 1.3 application data that arrives in the same UDP datagram after a KeyUpdate request. The parser now defers post-KeyUpdate tails and replays them after installing the next read keys, while keeping malformed or over-capacity tails from committing replay-window state.
Why
Without this, a peer can send KeyUpdate followed by app data in the next epoch in one datagram, and dimpl discards or mishandles the tail instead of processing it under the updated keys.
Notes
Validation
git diff --check 1b56b2f..HEADcargo fmt --checkcargo test --test dtls13 key_update --features rcgencargo test --all-targets --features rcgencargo clippy --all-targets --features rcgen -- -D warnings