dtls13: restore saved flight on resend failure#124
Draft
zRedShift wants to merge 6 commits into
Draft
Conversation
Owner
|
The sheer size of this one seems iffy. It also breaks architecture in multiple ways. |
5c15394 to
35088fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / stack notice
This is a stacked draft, not a standalone PR against
mainyet. GitHub currently shows the full dependency train in the diff.Dependency stack currently included in this branch:
dtls: defer replay commits until datagram parse succeedsdtls13: preserve app data after same-datagram KeyUpdatedtls13: preserve overlapping KeyUpdate flightsdtls13: bound ack tracking during handshake replacementThe actual #124-specific commit is only:
35088fedtls13: restore saved flight on resend failureSo this should be reviewed either after the dependency PRs land, or by comparing only against stack base
17475c7530ad62c5e9c6b87239f1327d2a6c6fca.Summary
Validation for the current stack base
cargo fmt --checkextern/scratch/dimpl/scripts/check-snowflake-local.pl 17475c7530ad62c5e9c6b87239f1327d2a6c6fcagit diff --check 17475c7530ad62c5e9c6b87239f1327d2a6c6fca..cargo test --test dtls13 key_update --features rcgencargo test --all-targets --features rcgencargo clippy --all-targets --features rcgen -- -D warningsCHANGELOG uses the expected PR number #124.