dtls13: preserve overlapping KeyUpdate flights#123
Draft
zRedShift wants to merge 3 commits into
Draft
Conversation
6ec361a to
1cbeac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft stacked on #122, which is itself stacked on #121. Once #121 and #122 land, this PR should be rebased onto
mainand its diff should collapse to the single DIMP-016 commit.What
This preserves overlapping DTLS 1.3 KeyUpdate flights instead of allowing one side of the overlap to erase the other side's pending update state. It also covers retransmission behavior so a duplicate KeyUpdate still gets a decryptable fresh ACK.
Why
When peers overlap KeyUpdate requests, dimpl can otherwise lose track of the local update or resend stale acknowledgement material. That breaks the DTLS 1.3 post-KeyUpdate state machine under valid overlapping traffic.
Notes
Validation
git diff --check 90989cf..HEADcargo fmt --checkcargo test --test dtls13 key_update --features rcgencargo test --all-targets --features rcgencargo clippy --all-targets --features rcgen -- -D warnings