Skip to content

feature: allow DeviceControl.wifi_connect to accept None as password #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Angel-Padilla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: allow DeviceControl.wifi_connect to accept None as password #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions nmcli/_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,13 @@ def wifi(self, ifname: str = None, rescan: bool = None) -> List[DeviceWifi]:

def wifi_connect(self,
ssid: str,
password: str,
password: str | None,
ifname: str = None,
wait: int = None) -> None:
cmd = add_wait_option_if_needed(
wait) + ['device', 'wifi', 'connect', ssid, 'password', password]
wait) + ['device', 'wifi', 'connect', ssid]
if password is not None:
cmd += ['password', password]
if ifname is not None:
cmd += ['ifname', ifname]
r = self._syscmd.nmcli(cmd)
Expand Down
18 changes: 18 additions & 0 deletions tests/test_device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,24 @@ def test_wifi_connect():
'--wait', '10', 'device', 'wifi', 'connect', ssid, 'password', password]


def test_wifi_connect_without_password():
s = DummySystemCommand()
device = DeviceControl(s)
ssid = 'Open AP'
ifname = 'wlan0'

device.wifi_connect(ssid, None)
assert s.passed_parameters == ['device', 'wifi', 'connect', ssid]

device.wifi_connect(ssid, None, ifname)
assert s.passed_parameters == [
'device', 'wifi', 'connect', ssid, 'ifname', ifname]

device.wifi_connect(ssid, None, wait=10)
assert s.passed_parameters == [
'--wait', '10', 'device', 'wifi', 'connect', ssid]


def test_wifi_connect_when_connection_activate_failed():
s = DummySystemCommand(
'''Error: Connection activation failed: (7) Secrets were required, but not provided.
Expand Down