feature: allow DeviceControl.wifi_connect to accept None as password#87
Open
Angel-Padilla wants to merge 1 commit into
Open
feature: allow DeviceControl.wifi_connect to accept None as password#87Angel-Padilla wants to merge 1 commit into
Angel-Padilla wants to merge 1 commit into
Conversation
This allows the package to call the `nmcli` util without passing a password as parameter, currently passing `None` would create the following command `sudo nmcli (--wait)? device wifi connect <SSID> password` which is an invalid command as it is missing the password argument, with this change the command will be `sudo nmcli (--wait)? device wifi connect <SSID>` allowing connection with open networks and networks already known by `nmcli`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the package to call the
nmcliutil without passing a password as parameter, currently passingNonewould create the following commandsudo nmcli (--wait)? device wifi connect <SSID> passwordwhich is an invalid command as it is missing the password argument, with this change the command will be
sudo nmcli (--wait)? device wifi connect <SSID>allowing connection with open networks and networks already known by
nmcliAfter the changes we would be opening the door to connect to OPEN networks and also to networks already known by
nmcliwithout the need of passing it's password again.