-
Notifications
You must be signed in to change notification settings - Fork 3.1k
5259_arm_cca_measured_boot_v1_s3: Enable CCEL ACPI table parsing in Acpiview #12534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samimujawar
wants to merge
2
commits into
tianocore:master
Choose a base branch
from
samimujawar:5259_arm_cca_measured_boot_v1_s3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Ccel/CcelParser.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /** @file | ||
| CCEL table parser | ||
|
|
||
| Copyright (c) 2025, Arm Limited. All rights reserved. | ||
| SPDX-License-Identifier: BSD-2-Clause-Patent | ||
|
|
||
| @par Reference(s): | ||
| - ACPI 6.5 Specification - 29 Aug 2022 | ||
| **/ | ||
|
|
||
| #include <IndustryStandard/Acpi.h> | ||
| #include <Library/UefiLib.h> | ||
| #include "AcpiParser.h" | ||
| #include "AcpiTableParser.h" | ||
| #include "AcpiViewConfig.h" | ||
|
|
||
| // Local variables. | ||
| STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; | ||
|
|
||
| /** | ||
| An ACPI_PARSER array describing the ACPI CCEL Table. | ||
| **/ | ||
| STATIC CONST ACPI_PARSER CcelParser[] = { | ||
| PARSE_ACPI_HEADER (&AcpiHdrInfo), | ||
| { L"CC Type", 1, 36, L"%d", NULL, NULL, NULL, NULL }, | ||
| { L"CC Subtype", 1, 37, L"%d", NULL, NULL, NULL, NULL }, | ||
| { L"Reserved", 2, 38, L"0x%x", NULL, NULL, NULL, NULL }, | ||
| { L"Log Area Minimum Length (LAML)",8, 40, L"0x%lx", NULL, NULL, NULL, NULL }, | ||
| { L"Log Area Start Address (LASA)",8, 48, L"0x%lx", NULL, NULL, NULL, NULL } | ||
| }; | ||
|
|
||
| /** | ||
| This function parses the ACPI CCEL table. | ||
| When trace is enabled this function parses the CCEL table and | ||
| traces the ACPI table fields. | ||
|
|
||
| @param [in] Trace If TRUE, trace the ACPI fields. | ||
| @param [in] Ptr Pointer to the start of the buffer. | ||
| @param [in] AcpiTableLength Length of the ACPI table. | ||
| @param [in] AcpiTableRevision Revision of the ACPI table. | ||
| **/ | ||
| VOID | ||
| EFIAPI | ||
| ParseAcpiCcel ( | ||
| IN BOOLEAN Trace, | ||
| IN UINT8 *Ptr, | ||
| IN UINT32 AcpiTableLength, | ||
| IN UINT8 AcpiTableRevision | ||
| ) | ||
| { | ||
| if (!Trace) { | ||
| return; | ||
| } | ||
|
|
||
| ParseAcpi ( | ||
| TRUE, | ||
| 0, | ||
| "CCEL", | ||
| Ptr, | ||
| AcpiTableLength, | ||
| PARSER_PARAMS (CcelParser) | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
There is a generic
DumpReserved()function and some other parsers validate the Reserved fields with a staticValidateResField()for instance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
Actually ValidateResField () is local to ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Agdi/AgdiParser.c so would need to move to AcpiParser.c. Also it may need some fixing.