5259_arm_cca_measured_boot_v1_s3: Enable CCEL ACPI table parsing in Acpiview#12534
Open
samimujawar wants to merge 2 commits intotianocore:masterfrom
Open
5259_arm_cca_measured_boot_v1_s3: Enable CCEL ACPI table parsing in Acpiview#12534samimujawar wants to merge 2 commits intotianocore:masterfrom
samimujawar wants to merge 2 commits intotianocore:masterfrom
Conversation
The RegisterParser() function is failing with error code EFI_OUT_OF_RESOURCES as we have run out of space for registering the ACPI table parsers in mTableParserList[]. Therefore, increase the MAX_ACPI_TABLE_PARSERS to 128. Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
The ACPI 6.5 specification introduces the CCEL (CC Event Log) table in section 5.2.34: https://uefi.org/specs/ACPI/6.5/ 05_ACPI_Software_Programming_Model.html#cc-event-log-acpi-table Extend AcpiView with a parser to decode and display CCEL table contents. This allows users to inspect CCEL tables from the UEFI Shell. Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
tianocore-assign-reviewers
Bot
requested review from
ajfish,
ardbiesheuvel,
leiflindholm,
makubacki,
mdkinney and
pierregondois
3 tasks
Contributor
pierregondois
left a comment
pierregondois
left a comment
There was a problem hiding this comment.
Hello Sami,
Just one small comment
| PARSE_ACPI_HEADER (&AcpiHdrInfo), | ||
| { L"CC Type", 1, 36, L"%d", NULL, NULL, NULL, NULL }, | ||
| { L"CC Subtype", 1, 37, L"%d", NULL, NULL, NULL, NULL }, | ||
| { L"Reserved", 2, 38, L"0x%x", NULL, NULL, NULL, NULL }, |
Contributor
There was a problem hiding this comment.
NIT:
There is a generic DumpReserved() function and some other parsers validate the Reserved fields with a static ValidateResField() for instance.
Contributor
Author
There was a problem hiding this comment.
Ack.
Actually ValidateResField () is local to ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Agdi/AgdiParser.c so would need to move to AcpiParser.c. Also it may need some fixing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable CCEL ACPI table parsing in Acpiview
This PR enhances the AcpiView command in ShellPkg by addressing parser scalability limitations and adding support for a new ACPI table.
Firstly, it increases the maximum number of supported ACPI table parsers from 32 to 128. This change resolves EFI_OUT_OF_RESOURCES failures encountered in RegisterParser() due to exhaustion of the parser list.
Secondly, it adds support for parsing the CCEL (Confidential Compute Event Log) ACPI table introduced in the ACPI 6.5 specification. A new parser is implemented and registered, enabling users to decode and inspect CCEL table contents from the UEFI Shell.
Note:
This PR is a subset of the PR that tracks the enablement of measured boot support for Arm CCA 5259_arm_cca_measured_boot_v1: Introduce measured boot support for Arm CCA #12531
This PR is dependent on 5259_arm_cca_measured_boot_v1_s2: Add CCEL and Arm CCA related definitions to MdePkg headers. #12533 which must be merged before this PR can be merged. The CI builds will also not succeed until then.
Breaking change?
Impacts security?
Includes tests?
How This Was Tested
Only build tested. Actual functionality can only be tested when the remaining patches from PR #12224 are integrated in the future.
Integration Instructions
N/A