Bug fixes for some RISCV64 platforms#910
Conversation
wxjstz
requested review from
ndhillonm,
vlsunil and
wojtas-marcin
as code owners
wxjstz
changed the title
|
The reason those platforms weren't included in #890 was that there were other issues with those ports preventing even build tests. If you can confirm that these changes make all of the affected platforms buildable, then please call that out explicitly. For any platforms that still won't build, please leave them as is. It provides a useful indication that they are not actively maintained and can be removed. |
Platform/SiFive/U5SeriesPkg/Universal/Dxe/RamFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
Outdated
Show resolved
Hide resolved
| !else | ||
| DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf | ||
| !endif | ||
| CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf |
There was a problem hiding this comment.
This addition goes beyond what is described in the commit message.
Please add a description of why it's needed.
There was a problem hiding this comment.
update commit message
Silicon/Bosc/NanHuPkg/Sec/SecMain.c
Outdated
| EFI_HOB_HANDOFF_INFO_TABLE *HobList; | ||
| EFI_RISCV_FIRMWARE_CONTEXT FirmwareContext; | ||
| RISCV_SEC_HANDOFF_DATA SecHandoffData; | ||
| const EFI_GUID SecHobDataGuid = RISCV_SEC_HANDOFF_HOB_GUID; |
There was a problem hiding this comment.
Please align the variable name with the surrounding ones.
Also please separate the assignment from the definition.
| DeviceTreeAddress | ||
| )); | ||
|
|
||
| FirmwareContext.BootHartId = BootHartId; |
There was a problem hiding this comment.
We are migrating from some sort of design to some other sort of design.
This is not the same as "add this hob which is required".
Can you expand the commit message slightly?
There was a problem hiding this comment.
update commit message
| ) | ||
| { | ||
| EFI_HOB_HANDOFF_INFO_TABLE *HobList; | ||
| EFI_RISCV_FIRMWARE_CONTEXT FirmwareContext; |
There was a problem hiding this comment.
Exactly the same comments as on Bosc/XiangshanSeriesPkg applies to this commit also.
There was a problem hiding this comment.
update commit message
Corrected the omission in tianocore#890 Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
Corrected the omission in tianocore#890 Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
I found redundant includes, when I tried to compile Platform/Bosc/XiangshanSeriesPkg/NanhuDev/NanhuDev.dsc Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
I found FvbServicesRuntimeDxe missing IoLib, when I tried to compile Platform/Bosc/XiangshanSeriesPkg/NanhuDev/NanhuDev.dsc Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
The booting info is now stored in SEC HOB GUID data. tianocore/edk2#11135 removed the firmware context and replaced it with SEC HOB Data. Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
1. Correct the path of CpuExceptionHandlerLib, different phases require their own CpuExceptionHandlerLib 2. Dw8250SerialPortLib.inf no longer exists; it has been replaced by BaseSerialPortLibRiscVSbiLibRam. 3. Correct the dependency on FdtLib Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
The booting info is now stored in SEC HOB GUID data. tianocore/edk2#11135 removed the firmware context and replaced it with SEC HOB Data. Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
1. Correct the path of CpuExceptionHandlerLib, different phases require their own CpuExceptionHandlerLib 2. Remove unnecessary RiscVFpuLib Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
Sophgo and XiangShang is buildable. |
| PACKAGE_VERSION = 1.0 | ||
|
|
||
| [Includes] | ||
| Include |
There was a problem hiding this comment.
That's probably the other platform's fault. It's typical for platforms to do this, it's how they bind #include directives to a path. Does the other board perhaps !include this file in its DEC/DSC? That would likely create issues, yes
4 participants
Some code needs to be updated due to changes in dependencies.