fix(ci): add msvc patches for ppx_expect#13978
Merged
Alizter merged 1 commit intoocaml:mainfrom Apr 7, 2026
Merged
Conversation
Alizter
force-pushed
the
push-ulksqmnxtpqo
branch
3 times, most recently
from
680f9fa to
3537c1b
Compare
Alizter
force-pushed
the
push-ulksqmnxtpqo
branch
from
3537c1b to
efd2d5b
Compare
Alizter
force-pushed
the
push-ulksqmnxtpqo
branch
2 times, most recently
from
e3471cb to
2a23913
Compare
Alizter
changed the title
Signed-off-by: Ali Caglayan <alizter@gmail.com>
punchagan
approved these changes
Apr 7, 2026
Collaborator
punchagan
left a comment
punchagan
left a comment
There was a problem hiding this comment.
I've also been able to separately try this on an MSVC switch locally and install ppx_expect.
Collaborator
Author
|
I forgot to add that Was rebased to test it. That PR will introduce expect tests on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following packages have upstream patches that fix the msvc build that have not been released yet. We pin them so that we can run ppx_expect with msvc:
ocaml_intrinsics_kernelbasetime_nowThis should be the last blocker for #13794.