feature(boot): strip let%expect_test#13794
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Apr 9, 2026
Merged
Conversation
rgrinberg
force-pushed
the
push-zuosywvzpmrs
branch
7 times, most recently
from
93be9d0 to
eb407d1
Compare
This was referenced Mar 31, 2026
Collaborator
rgrinberg
force-pushed
the
push-zuosywvzpmrs
branch
from
eb407d1 to
06db469
Compare
rgrinberg
pushed a commit
that referenced
this pull request
Apr 4, 2026
This lets us drop OCaml 4 from rocq support. This should unblock things like #13794. Signed-off-by: Ali Caglayan <alizter@gmail.com>
rgrinberg
force-pushed
the
push-zuosywvzpmrs
branch
from
06db469 to
6b9b248
Compare
Alizter
added a commit
that referenced
this pull request
Apr 6, 2026
We build more +ox packages from the oxcaml-repository via nix. Notably, ppx_expect now works and can be used for #13794.
Collaborator
|
#13978 is finished and once merged should allow for a green CI here. |
Alizter
added a commit
that referenced
this pull request
Apr 7, 2026
The following packages have upstream patches that fix the msvc build that have not been released yet. We pin them so that we can run ppx_expect with msvc: - `ocaml_intrinsics_kernel` - `base` - `time_now` This should be the last blocker for #13794.
rgrinberg
force-pushed
the
push-zuosywvzpmrs
branch
2 times, most recently
from
5f82a1f to
d9ef2e2
Compare
Collaborator
|
The oxcaml opam CI job is fixed here #14086 |
rgrinberg
force-pushed
the
push-zuosywvzpmrs
branch
2 times, most recently
from
47b2f39 to
8b36df4
Compare
allows us to write ppx_expect tests in more places without depending on the ppx itself As an example, add some unit tests for Dune_sexp.Escape. These will be handy once we drop support for pre 4.14 Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-zuosywvzpmrs
branch
from
8b36df4 to
36dda56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows us to write ppx_expect tests in more places without depending on the ppx itself
As an example, add some unit tests for Dune_sexp.Escape. These will be handy once we drop support for pre 4.14