-
Notifications
You must be signed in to change notification settings - Fork 564
WIP Undici migration p2 #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidgamero
wants to merge
9
commits into
kubernetes-client:main
Choose a base branch
from
davidgamero:undici-migration-p2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP Undici migration p2 #2813
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2597986
refactor: complete node-fetch to undici migration
davidgamero 300c014
refactor: remove dead TLS code in applySecurityAuthentication, drop n…
davidgamero 2ed869f
refactor(tests): deduplicate MockAgent setup into beforeEach/afterEac…
davidgamero d74afab
test: rename misnamed integration_test, add watch streaming integrati…
davidgamero 7a25b4f
fix(informer): treat TimeoutError as reconnectable, normalize timeout…
davidgamero d4f0853
refactor: rename awaitWithTimeout to withTimeout, fix unused cache va…
davidgamero eaddab8
tls-servername and keepalive compat
davidgamero e6690f1
Merge branch 'main' into undici-migration-p2
davidgamero 22b4078
sync package-lock
davidgamero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only real comment is that you could use the
node:timers/promisesversion ofsetTimeout()in a few places in this PR if you want, but it's optional.