WIP Undici migration p2 by davidgamero · Pull Request #2813 · kubernetes-client/javascript

davidgamero · 2026-03-26T15:22:24Z

node-fetch removals

rips out node-fetch and @types/node-fetch, uses native fetch (undici) everywhere
drops nock, migrates all test mocking to undici MockAgent
rewrite health, log, watch to use fetch() + Readable.fromWeb() for streaming
rename integration_test.ts → fullrequest_test.ts since it's a unit test

auth

removes applyToFetchOptions from kubeconfig (dead after migration)
cleans up dead tls config in applySecurityAuthentication (was set then immediately overwritten)

watch

treat watch TimeoutError as reconnectable in informer, add exponential backoff on reconnect
normalize timeout errors in watch.ts (fixes Node 23 mid-stream AbortError vs TimeoutError inconsistency)
add integration test for watch

informer

add informer reconnect integration test

…ock dependency, migrate cache_test to MockAgent

…h hooks

cjihrig · 2026-03-26T16:02:36Z

This is really great progress on modernizing the project. Thanks for working on it.

davidgamero · 2026-03-26T16:51:45Z

This is really great progress on modernizing the project. Thanks for working on it.

thanks! i was trying to remove nock so we can consolidate testing into undici mockagent and it snowballed

…on test

… errors, add exponential backoff + integration test

src/cache_test.ts

src/test/integration/watchPods.ts

src/test/integration/informerReconnect.ts

brendandburns · 2026-03-29T15:20:03Z

src/config.ts


        await this.applyOptions(httpsOptions);

-        if (cluster && cluster.skipTLSVerify) {


Should we be deleting this?

my reasoning is that the applyOptions call above invokes applyHTTPSOptions, which sets httpsOptions.rejectUnauthorized

this is mirrored into agentOptions below by agentOptions.rejectUnauthorized = httpsOptions.rejectUnauthorized;

servername is similarly applied in applyOptions > applyHTTPSOptions, but was missing the httpsOptions -> agentOptions conversion in this function which i've now added below along with a test calling the whole chain to assert the TLS propagation

happy to reasses my interpretation or refactor to improve readability

brendandburns · 2026-03-29T15:22:52Z

src/watch_test.ts

        strictEqual(doneCalled, 1);
    });

-    it('should call setKeepAlive on the socket to extend the default of 5 mins', async (t) => {


Does this test no longer apply?

it appears undici default keepalive is 60s which could still cause a race condition on some load balancers.

reintroduced updated test in config to keep 30s keepalive

brendandburns · 2026-03-29T15:23:55Z

Generally looks good, some comments on sleep() usage in one of the tests and a couple of things that I'm not sure why they were removed.

…rs in tests

cjihrig

This LGTM. I'll hold off on merging in case others want to weigh in first.

cjihrig · 2026-04-08T23:10:24Z

src/cache.ts

        this.listFn = listFn;
        this.labelSelector = labelSelector;
        this.fieldSelector = fieldSelector;
+        this.delayFn = options?.delayFn ?? ((ms) => new Promise((resolve) => setTimeout(resolve, ms)));


My only real comment is that you could use the node:timers/promises version of setTimeout() in a few places in this PR if you want, but it's optional.

k8s-ci-robot · 2026-04-08T23:11:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, davidgamero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cjihrig,davidgamero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mstruebing · 2026-04-09T06:22:50Z

src/util.ts

 // ApiException expects { [key: string]: string } whereas some fetch implementations provide: { [key: string]: string[] }
-// https://github.com/node-fetch/node-fetch/issues/783
-// https://github.com/node-fetch/node-fetch/pull/1757
 export function normalizeResponseHeaders(response: { headers: { entries(): Iterable<[string, string]> } }): {


Is this function still needed with undici? I remember adding it specifically for node-fetch.

davidgamero added 3 commits March 25, 2026 22:54

refactor: complete node-fetch to undici migration

2597986

refactor: remove dead TLS code in applySecurityAuthentication, drop n…

300c014

…ock dependency, migrate cache_test to MockAgent

refactor(tests): deduplicate MockAgent setup into beforeEach/afterEac…

2ed869f

…h hooks

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2026

k8s-ci-robot requested review from brendandburns and cjihrig March 26, 2026 15:22

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 26, 2026

davidgamero added 2 commits March 26, 2026 17:12

test: rename misnamed integration_test, add watch streaming integrati…

d74afab

…on test

fix(informer): treat TimeoutError as reconnectable, normalize timeout…

7a25b4f

… errors, add exponential backoff + integration test

davidgamero force-pushed the undici-migration-p2 branch from 60b46b0 to 7a25b4f Compare March 27, 2026 21:04

davidgamero commented Mar 28, 2026

View reviewed changes

src/cache_test.ts Outdated Show resolved Hide resolved

davidgamero commented Mar 28, 2026

View reviewed changes

src/test/integration/watchPods.ts Show resolved Hide resolved

brendandburns reviewed Mar 29, 2026

View reviewed changes

src/test/integration/informerReconnect.ts Outdated Show resolved Hide resolved

brendandburns reviewed Mar 29, 2026

View reviewed changes

src/test/integration/informerReconnect.ts Outdated Show resolved Hide resolved

brendandburns reviewed Mar 29, 2026

View reviewed changes

src/test/integration/informerReconnect.ts Outdated Show resolved Hide resolved

brendandburns reviewed Mar 29, 2026

View reviewed changes

davidgamero added 2 commits March 30, 2026 19:04

refactor: rename awaitWithTimeout to withTimeout, fix unused cache va…

d4f0853

…rs in tests

tls-servername and keepalive compat

eaddab8

davidgamero marked this pull request as ready for review April 1, 2026 05:38

k8s-ci-robot requested review from brendandburns and mstruebing April 1, 2026 05:38

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2026

Merge branch 'main' into undici-migration-p2

e6690f1

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2026

sync package-lock

22b4078

cjihrig approved these changes Apr 8, 2026

View reviewed changes

mstruebing reviewed Apr 9, 2026

View reviewed changes


		await this.applyOptions(httpsOptions);

		if (cluster && cluster.skipTLSVerify) {

Conversation

davidgamero commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig commented Mar 26, 2026

Uh oh!

davidgamero commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brendandburns Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

davidgamero Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

brendandburns Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

davidgamero Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Mar 29, 2026

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 8, 2026

Uh oh!

mstruebing Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

davidgamero commented Mar 26, 2026 •

edited

Loading

davidgamero Apr 1, 2026 •

edited

Loading