fix bug: mapping from msgpack response to int, Integer, long, Long types works fine#671
fix bug: mapping from msgpack response to int, Integer, long, Long types works fine#671chabapok wants to merge 1 commit intoinfluxdata:masterfrom
Conversation
|
Nice catch, one small formatting nit: |
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=========================================
Coverage 88.18% 88.18%
Complexity 722 722
=========================================
Files 69 69
Lines 2513 2513
Branches 268 268
=========================================
Hits 2216 2216
Misses 208 208
Partials 89 89
Continue to review full report at Codecov.
|
|
I'm reviewing this PR. Please, do not merge. |
|
Did anything ever happen with this one? |
|
What is a progress on this? |
|
Hi @fmachado, any update on this PR? |
|
I think he stopped working on this a long time ago. That's left a lot of PRs unmerged and most have likely gone to the influxdb-client-java repo. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
=========================================
Coverage 88.18% 88.18%
Complexity 722 722
=========================================
Files 69 69
Lines 2513 2513
Branches 268 268
=========================================
Hits 2216 2216
Misses 208 208
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All of the unit tests of the
InfluxDBResultMapperis based on the assumption that all numbers in response from influxd isDouble. It will be ok withJSON. Butmsgpackformat is more precise.So,
InfluxDBResultMapperhave errors. For example, it throws an exception when mapping number toint,Integer,long,Longtypes frommsgpackresponses, but works withjson.This PR fix it (with unit test).