Use MessagePack instead of JSON serialization#12
Merged
hgomez merged 1 commit intohgomez:masterfrom Mar 4, 2021
Merged
Conversation
Apparently, JSON serialization had many flaws in the past and some of them might even hold true and can't be fixed. tldr: If you are using InfluxDB 1.4+, use the ResponseFormat.MessagePack when creating your InfluxDB client.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Henri.
Apparently, the default JSON serialization used under the hood when talking to InfluxDB had many flaws in the past and some of them might even hold true and can't be fixed. I found about about this when reading a bit into influxdata/influxdb-java#671, influxdata/influxdb-java#406, influxdata/influxdb-java#153 (comment) and square/moshi#192.
So, I would suggest to follow @fmachado's recommendation at influxdata/influxdb-java#440 (comment):
This patch implements just that.
With kind regards,
Andreas.