Skip to content

Fix crash caused by phantasm support being copied with mirage skills that take over mainSKill #9732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paliak wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −14
Open

Fix crash caused by phantasm support being copied with mirage skills that take over mainSKill #9732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions src/Modules/CalcMirages.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ local function calculateMirage(env, config)
if mirageSkill then
local newSkill, newEnv = calcs.copyActiveSkill(env, "CALCULATOR", mirageSkill)
newSkill.skillCfg.skillCond["usedByMirage"] = true
newSkill.skillFlags.multiPart = nil
newSkill.skillFlags.haveMinion = nil
newEnv.limitedSkills = newEnv.limitedSkills or {}
newEnv.limitedSkills[cacheSkillUUID(newSkill, newEnv)] = true
newSkill.skillData.mirageUses = env.player.mainSkill.skillData.storedUses
Expand Down Expand Up @@ -150,21 +152,8 @@ function calcs.mirages(env)
postCalcFunc = function(env, newSkill, newEnv)
env.player.mainSkill = newSkill
env.player.mainSkill.infoMessage = tostring(maxMirageWarriors) .. " Mirage Warriors using " .. newSkill.activeEffect.grantedEffect.name

-- Re-link over the output
env.player.output = newEnv.player.output
if newSkill.minion then
env.minion = newEnv.player.mainSkill.minion
env.minion.output = newEnv.minion.output
end

-- Re-link over the breakdown (if present)
if newEnv.player.breakdown then
env.player.breakdown = newEnv.player.breakdown
if newSkill.minion then
env.minion.breakdown = newEnv.minion.breakdown
end
end
env.player.breakdown = newEnv.player.breakdown or env.player.breakdown
end,
mirageSkillNotFoundFunc = function(env, config)
env.player.mainSkill.disableReason = "No Saviour active skill found"
Expand Down
Loading