Fix crash caused by phantasm support being copied with mirage skills that take over mainSKill#9732
Open
Paliak wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Fix crash caused by phantasm support being copied with mirage skills that take over mainSKill#9732Paliak wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Paliak wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
… that take over mainSKill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9706
Description of the problem being solved:
Currently
ReflectionfromThe Savioursort of allowed for handling of phantasms on mirages that copy mainSkill. This caused issues with breakdown as theCALCULATORenv mode does not generate breakdown and theCALCSmode expect the breakdown to be present. This pr fixes the issue by disabling minion handling onReflection. The summon phantasm dps can still be seen on the main skill.Steps taken to verify a working solution: