Skip to content

fix(Basic): use static_cast of Singleton instance#1255

Merged
BotellaA merged 2 commits intonextfrom
fix/dyn-cast-singleton
Mar 27, 2026
Merged

fix(Basic): use static_cast of Singleton instance#1255
BotellaA merged 2 commits intonextfrom
fix/dyn-cast-singleton

Conversation

@panquez
Copy link
Copy Markdown
Member

@panquez panquez commented Mar 27, 2026

No description provided.

@panquez panquez requested a review from BotellaA March 27, 2026 16:21
@github-actions github-actions bot changed the base branch from master to next March 27, 2026 16:21
@github-actions
Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 1 concern(s)
  • include/geode/basic/singleton.hpp:67:17: warning: [cppcoreguidelines-owning-memory]

    assigning newly created 'gsl::owner<>' to non-owner 'Singleton *'

       67 |                 singleton = new SingletonType{};
          |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit a90a4e3 into next Mar 27, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/dyn-cast-singleton branch March 27, 2026 21:35
@BotellaA
Copy link
Copy Markdown
Member

🎉 This PR is included in version 16.3.3-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA
Copy link
Copy Markdown
Member

🎉 This PR is included in version 16.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants