Merge pull request #1255 from Geode-solutions/fix/dyn-cast-singleton

fix(Basic): use static_cast of Singleton instance

Author: BotellaA

.clang-tidy

@@ -19,7 +19,8 @@ Checks: >
   -readability-use-anyofallof,
   -readability-redundant-access-specifiers,
   -readability-convert-member-functions-to-static,
-  -cppcoreguidelines-avoid-const-or-ref-data-members
+  -cppcoreguidelines-avoid-const-or-ref-data-members,
+  -cppcoreguidelines-pro-bounds-constant-array-index
 
 CheckOptions:
   - key: misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic

include/geode/basic/singleton.hpp

@@ -61,14 +61,13 @@ namespace geode
         {
             const auto& type = typeid( SingletonType );
             const std::lock_guard< std::mutex > locking{ lock() };
-            auto* singleton =
-                dynamic_cast< SingletonType* >( instance( type ) );
+            auto* singleton = instance( type );
             if( singleton == nullptr )
             {
                 singleton = new SingletonType{};
                 set_instance( type, singleton );
             }
-            return *singleton;
+            return *static_cast< SingletonType* >( singleton );
         }
 
     private: