This repository was archived by the owner on Sep 26, 2019. It is now read-only.
Fixing bug where retire_limit is never met in Mark#540
Open
nonword wants to merge 2 commits into
Open
Conversation
…entation, which rightly expects a percentage of completion_assessment_votes
… return code indicating success
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally workflow.retire_limit was an int (e.g. 3). Later, after implementing the completion_assessment_task we realized this should be a percentage (e.g. 0.75) to establish the target majority threshold when multiple conflicting completion_assessment votes have been cast. (In the future, we might modify this to take the time into account - so that a lot of early "yes" votes do not dominate later equally legitimate "no" votes.) In any case, we've configured our workflows with retire_limit 3, but we're checking that against the percentage of "no" votes when determining whether or not to retire. But [number of "no" votes] / [number of votes] will never be greater than 1 much less 3, so nothing is retired.
Also adding Emigrant discuss url.