(feat): acorn 5.0#22
Open
rivanuff wants to merge 15 commits into
Open
Conversation
rivanuff
requested review from
a team,
Rovasch,
SimonvanWijhe,
YvetteNikolov,
dtakken,
hnccox-yard,
ictbeheer,
mvdhoek1 and
robertbossaert
and removed request for
a team
Composer package changes
|
rivanuff
changed the title
Member
rivanuff
commented
Aug 30, 2025
| ->withMiddleware(function (Middleware $middleware) { | ||
| $middleware->append(AddCspHeaders::class); | ||
| }) | ||
| ->withRouting(wordpress: true) |
Author
There was a problem hiding this comment.
Heb wat getest hiermee, wordpress: true zorgt er iig voor dat de CSP headers niet meer via brave-hooks dmv de send_headers hook moeten worden toegevoegd.
SimonvanWijhe
force-pushed
the
feat/acorn-5
branch
from
9d90bd4 to
4d2fe35
Compare
Contributor
|
Bij deze even opletten dat deze commit er ook in verwerkt wordt: 5113678 |
rivanuff
requested review from
ShunLuk and
SimonvanWijhe
and removed request for
hnccox-yard and
robertbossaert
There was a problem hiding this comment.
Pull request overview
Updates this package to support Roots Acorn v5 and PHP 8.2, replacing the prior Acorn v4 bootloader customization approach with the new configuration/builder style used by Acorn 5.
Changes:
- Upgrade platform/runtime requirements to PHP 8.2 and bump Acorn + dev tooling dependencies.
- Rework
bootloader()to useApplication::configure()with exception + middleware configuration hooks. - Remove now-redundant custom Kernel/Handler/Vite wrapper classes and adjust view composer attachment logic.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/helpers.php |
Switch bootstrapping to Acorn 5 Application::configure() and configure bindings/exceptions/middleware. |
src/View/ViewServiceProvider.php |
Simplify composer config check when attaching view composers. |
src/Http/Kernel.php |
Remove custom HTTP kernel (CSP now configured via middleware hook). |
src/Exceptions/Handler.php |
Remove custom exception handler (Sentry now configured via exceptions hook). |
src/Assets/Vite.php |
Remove custom Vite wrapper class. |
composer.json |
Bump PHP + Acorn requirements and update dev tooling versions. |
README.md |
Update documented PHP requirement and bootloader usage example. |
.github/workflows/phpstan.yml |
YAML formatting/quoting update for PR path filters. |
.github/workflows/format-php.yml |
YAML formatting/quoting update for PR path filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
15
to
17
| /** @var array<Composer> */ | ||
| $composers = $this->app->get('config')->get('view.composers', []); | ||
|
|
rivanuff
force-pushed
the
feat/acorn-5
branch
2 times, most recently
from
72a8032 to
3290497
Compare
Co-authored-by: Dik Takken <dik.takken@yard.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voorbeeld van implementatie:
https://github.com/yardinternet/UMCNL/pull/68