feat: (W-003) Legacy compatibility adapter for 3.x to 4.0 migration#2015
Open
feat: (W-003) Legacy compatibility adapter for 3.x to 4.0 migration#2015
Conversation
Backward compatibility adapter that provides: - DeprecationLogger with configurable modes (silent/log/warn/error) - Controller mixin shims for deprecated APIs (renderPage, renderPageToString) - MigrationScanner that analyzes app code for legacy patterns - Three-stage progressive migration path (install → migrate → remove) Verified on Lucee 6 and Adobe CF 2025. Core tests pass with 0 regressions. Closes #1969 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove this.version from LegacyAdapter.cfc, source version from package.json - Add pathFilter to MigrationScanner for context-aware this.version detection (only flags files in plugins/ directory, avoiding false positives) - Remove $legacyPaginationLinks shim (no migration value) - Move test-path check from inner loop to early return for efficiency - Update tests: add path-filter verification, update $scanContent helper to accept subDir parameter for simulating file locations - Revise plan: fix mixin scope to controller, demote Plugin-to-Package Bridge to Plugin Diagnostics, remove phantom showErrors setting, remove false-premise unresolved question, reframe edge cases Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ter tests DirectoryCreate(path, true) is Lucee-only — Adobe CF only accepts 1 parameter. Replace with Java File.mkdirs() which works on all CFML engines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
docs
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
wheels-legacy-adapterpackage — a backward compatibility layer for smooth migration from Wheels 3.x to 4.0.renderPage()→renderView()andrenderPageToString()→renderView(returnAs="string"), plus plugin diagnostics via$legacyPluginInfo()plugins/directory to avoid false positives)Migration path
vendor/legacyadapter— existing 3.x code works unchangederrorto catch stragglers, then remove adapterAlso includes
legacyadapterpackagecontinue-on-errorfor auto-label job on fork PRsCloses #1969
Test plan
🤖 Generated with Claude Code