Enable estimateContentLength to fix gapless playback issues.#54
Open
stuaxo wants to merge 1 commit intowarwickh:masterfrom
Open
Enable estimateContentLength to fix gapless playback issues.#54stuaxo wants to merge 1 commit intowarwickh:masterfrom
stuaxo wants to merge 1 commit intowarwickh:masterfrom
Conversation
disabled which can cause playback issues + affect gapless playback.
Author
|
This is an attempt to fix playback issues (gaps) on Android TV. |
dskvr
added a commit
to sandwichfarm/plugin.audio.subsonic
that referenced
this pull request
Apr 28, 2026
4 plans in 3 waves: PR warwickh#53 (settings.xml) and PR warwickh#54 (play_track) parallel in Wave 1; PR warwickh#49 (Favorite Albums) in Wave 2; smoke verify + human checkpoint in Wave 3. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dskvr
added a commit
to sandwichfarm/plugin.audio.subsonic
that referenced
this pull request
Apr 28, 2026
… playback (Co-authored) - Add estimateContentLength=True to connection.streamUrl() in play_track() - Enables Kodi to pre-buffer next track for gapless playback on supported builds - Closing paren at 4-space indent (matching codebase style, not the 3-space from PR) Co-Authored-By: Stuart Axon <stuaxo2@gmail.com>
dskvr
added a commit
to sandwichfarm/plugin.audio.subsonic
that referenced
this pull request
Apr 28, 2026
… verified - pytest 6/6 pass with PR warwickh#53 (m4a), warwickh#54 (gapless), warwickh#49 (favorites) applied - Human checkpoint approved; Phase 2 marked complete in ROADMAP.md - PR-01, PR-02, PR-03 requirements already marked complete by prior agents Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dskvr
added a commit
to sandwichfarm/plugin.audio.subsonic
that referenced
this pull request
Apr 28, 2026
- @route('play_track') registered using setResolvedUrl (never endOfDirectory) - Delegates stream URL to client.stream_url(track_id, bitrate, fmt) - EstimateContentLength property set for gapless playback (PR warwickh#54) - Specific exception handling with log_exception (no bare except) - from __future__ import annotations + full type hints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable estimateContentLength, without it set the readahead buffer is disabled which can cause playback issues + affect gapless playback.