Skip to content

Always show workflow editor close button (#10387)#10540

Merged
seemeroland merged 2 commits into
warpdotdev:masterfrom
SagarSDagdu:sagar/workflow-editor-close-button-10387
May 13, 2026
Merged

Always show workflow editor close button (#10387)#10540
seemeroland merged 2 commits into
warpdotdev:masterfrom
SagarSDagdu:sagar/workflow-editor-close-button-10387

Conversation

@SagarSDagdu
Copy link
Copy Markdown
Contributor

@SagarSDagdu SagarSDagdu commented May 9, 2026

Description

Fixes #10387 — the "x" close button on the workflow/alias editor pane is currently hidden until the header is hovered, which makes dismissal hard to discover. Users may attempt to close the editor via the vertical tabs "x" instead, which closes the entire session.

This change sets always_show_icons = true on the standard header options returned by WorkflowView::render_header_content, so the pane's close button stays persistently visible — matching the pattern already used by network_log_view and ai/execution_profiles/editor.

Single-file change in app/src/workflows/workflow_view.rs.

Linked Issue

  • The linked issue is labeled ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below.

Closes #10387

Screenshots / Videos

https://www.loom.com/share/34f7fb67766041b684877ef923d222c2

Testing

  • Built and ran Warp locally; opened a new personal workflow and confirmed the close button in the top-right of the editor pane is visible without hovering the header.
  • Ran cargo fmt and cargo clippy -p warp --bin warp-oss --all-targets (clean).

No automated test added: similar UX-flag fixes elsewhere in the codebase (network_log_view.rs, ai/execution_profiles/editor/mod.rs) toggle always_show_icons without dedicated tests, since the change is a single render-time boolean and asserting on rendered header visibility would require new test scaffolding (a HeaderRenderContext test fixture and a WorkflowView singleton-soup setup) for limited additional confidence.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

The "x" close affordance on the workflow/alias editor pane was hidden
until the header was hovered, making dismissal hard to discover and
easy to confuse with closing the entire session via the vertical tabs.

Set `always_show_icons = true` on the standard header options for
`WorkflowView::render_header_content` so the close button is
persistently visible, matching the pattern already used by
`network_log_view` and `execution_profiles/editor`.
@cla-bot cla-bot Bot added the cla-signed label May 9, 2026
@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 9, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 9, 2026

@SagarSDagdu

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @seemeroland.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates WorkflowView header rendering so standard header icons, including the close button, are always visible for the workflow/alias editor pane.

Concerns

  • None found in the reviewed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from seemeroland May 9, 2026 02:36
Copy link
Copy Markdown
Contributor

@seemeroland seemeroland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! We might consider making always showing icons the default (maybe we should do this for warp drive notebooks and env vars as well), but okay to leave out of scope here

@seemeroland seemeroland enabled auto-merge (squash) May 11, 2026 19:30
@SagarSDagdu
Copy link
Copy Markdown
Contributor Author

SagarSDagdu commented May 12, 2026

@seemeroland
The Warp CI / Run Windows tests is flaky.
I have merged the latest upstream master, please re-trigger the workflows and lets hope this time it passes 🤞🏻

@seemeroland seemeroland merged commit 6df2cc0 into warpdotdev:master May 13, 2026
23 checks passed
@SagarSDagdu SagarSDagdu deleted the sagar/workflow-editor-close-button-10387 branch May 14, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "x" to close workflow (alias) builder UI more intuitive and persistent

2 participants