fix: preserve Windows Explorer new tab directory#10464
Draft
lllakshit wants to merge 1 commit intowarpdotdev:masterfrom
Draft
fix: preserve Windows Explorer new tab directory#10464lllakshit wants to merge 1 commit intowarpdotdev:masterfrom
lllakshit wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @lllakshit on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9844.
Windows Explorer's
Open Warp in new tabregistry entries now pass the selected folder/background folder as afile:///...URI, which routes through Warp's existing file URI handling and preserves the target directory when creating the session.This also hardens the custom
action/new_tab?path=...parser so it can handle shell-quoted paths andfile://path values, and updates Windows single-instance forwarding to append the current directory throughUrl::query_pairs_mut()instead of concatenating an unescaped query string.Linked Issue
ready-to-implement.Testing
git diff --checkfile://tab path values.Not run locally because this Windows machine does not currently have the required developer tools available on PATH:
cargorustfmtisccAgent Mode
CHANGELOG-BUG-FIX: Fixed Windows Explorer's
Open Warp in new tabcontext menu action losing the selected folder and opening at the home directory.