sending MultiPart in http client Fix #1005#1876
sending MultiPart in http client Fix #1005#1876WebFreak001 wants to merge 11 commits intovibe-d:masterfrom
Conversation
s-ludwig
left a comment
There was a problem hiding this comment.
While reviewing the changes, I came to the conclusion that this needs a deeper API change to work efficiently with the non-class streams of vibe-core. What I would propose is to drop the MultiPart(BodyPart)' class(es) completely and change the signature of writeParttovoid writePart(InputStream)(InputStream content, in ref InetHeaderMap headers = emptyHeaderMap) if (isInputStream!InputStream)`. That would avoid the need for a proxy that does dynamic dispatch and destroys all inlining possibilities.
Of course there can still be the convenience overloads that take other kinds of types for content.
|
@s-ludwig ping |
|
@s-ludwig pong |
|
@s-ludwig bump... I need this yet again... |
This comment has been minimized.
This comment has been minimized.
|
ping |
|
Any plans on merging this? @s-ludwig |
|
bump @s-ludwig
|
this is also testing the server implementation which made me find #1875