fix(.claude): add session-start-profiler hook with Windows-aware CLI detection#15698
Open
sleitor wants to merge 1 commit intovercel:mainfrom
Open
fix(.claude): add session-start-profiler hook with Windows-aware CLI detection#15698sleitor wants to merge 1 commit intovercel:mainfrom
sleitor wants to merge 1 commit intovercel:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 20a89cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Low Risk — New developer tooling hook for CLI detection — no auth, billing, schema, or shared infrastructure changes.
Assessed at 20a89cd. |
…detection Adds `.claude/hooks/session-start-profiler.mjs` — a Claude Code SessionStart hook that warns when the Vercel CLI is not installed. On Windows, npm installs an extensionless wrapper script (e.g. `vercel`) alongside `vercel.CMD` and `vercel.EXE`. The extensionless file passes `fs.accessSync(X_OK)` but cannot be spawned directly via `execFileSync`, causing a false "CLI not installed" warning. The hook now probes `.CMD` and `.EXE` candidates BEFORE the extensionless name on Windows. Closes vercel#15697
Contributor
Author
|
Rebased on latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.claude/hooks/session-start-profiler.mjs— a Claude CodeSessionStarthook that checks whether the Vercel CLI is installed and prints a helpful message if not.Fixes the Windows false-negative reported in #15697.
Root Cause
On Windows, npm installs an extensionless wrapper script (e.g.
C:\Users\<user>\AppData\Roaming\npm\vercel) alongside the actual launchersvercel.CMDandvercel.EXE. The extensionless file passesfs.accessSync(constants.X_OK), so it was returned first as the resolved binary — butchild_process.execFileSynccannot spawn it directly and throwsENOENT. The hook catches that error and (incorrectly) concludes the CLI is not installed.Fix
resolveBinaryFromPathnow probes.CMDand.EXEcandidates before the extensionless name on Windows. The first candidate that both exists+is-executable AND can be successfully spawned is returned.Changes
.claude/hooks/session-start-profiler.mjs— new SessionStart hook.claude/settings.json— registers the hook for Claude Code.changeset/fix-claude-hooks-windows-binary.md— empty-frontmatter changeset (non-package file change)Closes #15697