Skip to content

⚡ Improve ModelInfoMgr::FindDummies performance by using iterative traversal #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CanerKaraca23 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Improve ModelInfoMgr::FindDummies performance by using iterative traversal #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions src/utils/modelinfomgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,25 +100,33 @@ void ModelInfoMgr::EnableStrobeMaterial(CVehicle *pVeh, int idx)

void ModelInfoMgr::FindDummies(CVehicle *vehicle, RwFrame *frame)
{
if (frame)
{
if (RwFrame *nextFrame = frame->child)
{
FindDummies(vehicle, nextFrame);
}
if (!frame) return;

if (RwFrame *nextFrame = frame->next)
{
FindDummies(vehicle, nextFrame);
}
std::vector<RwFrame*> stack;
std::vector<RwFrame*> nodes;
stack.reserve(128);
nodes.reserve(128);
Comment on lines +105 to +108

std::string_view nodeName = GetFrameNodeName(frame);
for (auto e : dummy)
{
e(vehicle, frame, nodeName);
stack.push_back(frame);

while (!stack.empty()) {
RwFrame* curr = stack.back();
stack.pop_back();

nodes.push_back(curr);

if (curr->child) stack.push_back(curr->child);
if (curr->next) stack.push_back(curr->next);
}
Comment on lines +105 to +120

for (auto it = nodes.rbegin(); it != nodes.rend(); ++it) {
RwFrame* curr = *it;
std::string_view nodeName = GetFrameNodeName(curr);
for (auto e : dummy) {
e(vehicle, curr, nodeName);
}
}
};
}

void ModelInfoMgr::Reload(CVehicle *pVeh)
{
Expand Down
Loading