[OSS-components] Rework the solution from custom hasHtmlText assertion#670
Open
edouardmisset wants to merge 2 commits into
Open
[OSS-components] Rework the solution from custom hasHtmlText assertion#670edouardmisset wants to merge 2 commits into
edouardmisset wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the custom
hasHtmlTextassertion that was introduced in PR #652 and bumpsqunit-domto^3.3.0which ships a nativehasHtml()method.The custom assertion created a throwaway DOM element (
document.createElement('div')) to parse HTML and compare text content — this approach "fakes reality" as flagged by Philippe. Withqunit-dom3.3+, we can use the built-inassert.dom(selector).hasHtml(expectedHtml)instead.Related to: #DRA-4875
What are the observable changes?
assert.hasHtmlText()assertion is no longer availablequnit-domis upgraded from^3.0.0to^3.3.0, makingassert.dom(selector).hasHtml()available as a replacementGood PR checklist