Skip to content

track-container-exits#5308

Draft
Flo4604 wants to merge 1 commit intomainfrom
feat/track-container-exits
Draft

track-container-exits#5308
Flo4604 wants to merge 1 commit intomainfrom
feat/track-container-exits

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Mar 13, 2026

What does this PR do?

Enhances deployment failure handling by displaying detailed instance error messages in the failed deployment banner and network visualization. When deployments fail due to instance issues (like crashes or OOM kills), users now see specific error messages instead of generic "Deployment failed" text.

Adds support for post-deploy failures where the deployment pipeline completes successfully but instances fail afterward. The system now properly detects these scenarios and shows the failed deployment banner with relevant error details.

Fixes #5302

Type of change

  • Enhancement (small improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Deploy an application that will crash or fail to start
  • Verify the failed deployment banner shows specific error messages instead of generic text
  • Test deployments that complete pipeline but have instances fail afterward
  • Check that instance nodes in the network view display error messages as subtitles
  • Verify the sentinel instances panel shows error messages for unhealthy instances

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Mar 24, 2026 9:40am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8be1629b-cb57-42af-9044-354c567cc615

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/track-container-exits

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member Author

Flo4604 commented Mar 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect broken containers that exit with code 0

1 participant