feat(clean): group Python bytecode cleanup by project root#634
feat(clean): group Python bytecode cleanup by project root#634
Conversation
|
May close issue #633. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb249f5d92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@byronwang2005 LGTM! This directly addresses a well-reported pain point (#633), grouping by project root turns 1000+ noisy lines into clean per-project summaries. The decomposition is solid and the existing safety checks (whitelist, protect path, dry-run) are all preserved. A couple of minor things worth tidying up in a follow-up if you have time:
None of these are blockers. Thanks for tackling this one! |
Summary
__pycache__directory.Safety Review
cleanbehavior for project cache cleanup, specifically Python__pycache__handling and the timing/format of project-cache output.SKIPPEDoperation logs.__pycache__targets.Tests
./scripts/check.sh./scripts/test.sh(current repo still has unrelated existing failures intests/cli.batsformo status --json)bats tests/clean_system_caches.bats -f "clean_project_caches completes without errors"bats tests/clean_system_caches.bats -f "clean_project_caches groups pycache directories by project root"bats tests/clean_system_caches.bats -f "clean_project_caches pycache dry-run exports grouped targets and counts skips"bats tests/clean_dev_caches.bats -f "clean_project_caches cleans flutter .dart_tool and build directories"./mo clean --dry-runglobally and verified Python bytecode cleanup now prints grouped project-root summaries.__pycache__directories to confirm several0B drycases were due to empty cache directories, not size-calculation regression.Safety-related changes