feat(import): support jlcpcb identifiers in import flow#3119
Open
techmannih wants to merge 2 commits into
Open
feat(import): support jlcpcb identifiers in import flow#3119techmannih wants to merge 2 commits into
techmannih wants to merge 2 commits into
Conversation
seveibar
requested changes
May 27, 2026
Contributor
seveibar
left a comment
There was a problem hiding this comment.
Add representative usage
there appear to be unrelated changes?
Contributor
|
Or snapshot output, not sure i understand what you’re doing because there is no proper integration test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
importflow to understand and display provider-prefixed JLCPCB identifiers.It is intentionally scoped separately from the search formatting change in #3118.
Why
After adding
jlcpcb:C...identifiers to CLI search output, the import flow still had two gaps:C...or numeric part numbersC...values instead of the provider-prefixed identifierThat made the
search -> importworkflow feel inconsistent and made the identifier format harder to use end-to-end.What changed
jlcpcb:C1234,C1234, and bare numeric part numbers in direct JLCPCB import parsingjlcpcb:C...identifiers in JLCPCB import selection labelsUser impact
tsci import jlcpcb:C2040now workstsci import C2040andtsci import 2040continue to worktsci importnow use the same provider-prefixed format users see elsewhereValidation
bun test tests/cli/import/parse-direct-lcsc-part-number.test.ts tests/cli/import/format-jlcpcb-import-choice-title.test.tsbunx biome check cli/import/register.ts cli/import/parse-direct-lcsc-part-number.ts cli/import/format-jlcpcb-import-choice-title.ts lib/shared/jlcpcb-part-number.ts lib/shared/jlcpcb-component.ts tests/cli/import/parse-direct-lcsc-part-number.test.ts tests/cli/import/format-jlcpcb-import-choice-title.test.ts