fix:reject non-STATUS messages on discovery channels#133
Open
xxo1shine wants to merge 1 commit into
Open
Conversation
A peer can reply with a HelloMessage on a discovery probe channel to trick the node into running the full handshake path: the channel ends up in ChannelManager.channels, onConnect fires, and finishHandshake is set, polluting the connection table and consuming a maxConnections slot. Guard processMessage so a channel in discoveryMode only accepts STATUS and is closed otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A peer can reply with a HelloMessage on a discovery probe channel to trick the node into running the full handshake path: the channel ends up in ChannelManager.channels, onConnect fires, and finishHandshake is set, polluting the connection table and consuming a maxConnections slot. Guard processMessage so a channel in discoveryMode only accepts STATUS and is closed otherwise.
Why are these changes required?
This PR has been tested by:
Extra details