feat(net): normalize inbound messages#6797
Open
halibobo1205 wants to merge 2 commits into
Open
Conversation
halibobo1205
changed the title
halibobo1205
changed the title
halibobo1205
changed the title
halibobo1205
changed the title
- BlockMessage strips Block and BlockHeader outer unknown fields and enforces the existing BLOCK_SIZE + ONE_THOUSAND cap before parsing. - TransactionMessage strips top-level transaction unknown fields and rejects oversized transactions with Manager.validateCommon-equivalent size checks after parsing. - TransactionsMessage strips wrapper and nested transaction top-level unknown fields and applies the same per-transaction size check to each entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize inbound BlockMessage / TransactionMessage / TransactionsMessage.
Sanitize is applied only on the byte[] constructors. Object-form constructors (BlockMessage(BlockCapsule), TransactionMessage(Transaction), TransactionsMessage(List)) keep existing behavior.
Note
A fast path on UnknownFieldSet.asMap().isEmpty() keeps the common
no-unknown-fields case allocation-free.