fix(tvm): canonicalize ModExp zero modulus output (TIP-871)#6779
Closed
yanghang8612 wants to merge 1 commit into
Closed
fix(tvm): canonicalize ModExp zero modulus output (TIP-871)#6779yanghang8612 wants to merge 1 commit into
yanghang8612 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALLOW_TVM_OSAKAMotivation
Related to tronprotocol/tips#871. MODEXP currently returns empty output for an all-zero modulus even when
modLen > 0; after Osaka it should returnmodLenzero bytes. CREATE2 also needs to match CREATE by clearing stale return-data state before execution once the Osaka behavior is active.Testing