fix(compat/isNaN): improve NaN checks for boxed values and non-numbers#1646
Open
fix(compat/isNaN): improve NaN checks for boxed values and non-numbers#1646
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the compat/predicate/isNaN helper to correctly detect NaN for boxed number values (e.g. new Number(NaN)) while still returning false for non-numeric inputs, aligning behavior more closely with lodash.
Changes:
- Update
isNaNimplementation to gate onisNumberand handle boxed numbers via numeric unboxing. - Extend
isNaNtests to cover boxed number inputs (new Number(0)andnew Number(NaN)).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/compat/predicate/isNaN.ts | Changes isNaN logic to handle boxed numbers via unboxing after a numeric-type gate. |
| src/compat/predicate/isNaN.spec.ts | Adds test cases for boxed non-NaN and boxed NaN values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ing Number.prototype
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 497 497
Lines 4660 4660
Branches 1348 1349 +1
=======================================
Hits 4659 4659
Misses 1 1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.