feat: track 'oauthFailed', 'oauthInitiated' event for audit#472
Open
feat: track 'oauthFailed', 'oauthInitiated' event for audit#472
Conversation
| "@toruslabs/metadata-helpers": "^8.2.0", | ||
| "@toruslabs/session-manager": "^5.6.0", | ||
| "@toruslabs/torus.js": "^17.2.2", | ||
| "@toruslabs/torus.js": "file:./toruslabs-torus.js-17.2.2.tgz", |
There was a problem hiding this comment.
Local tgz file dependency accidentally committed
High Severity
The @toruslabs/torus.js dependency is pointed at file:./toruslabs-torus.js-17.2.2.tgz instead of the npm registry. This local file reference will fail to resolve for other developers, CI pipelines, and consumers of this package. This appears to be a development/testing artifact that needs to be reverted to the registry version before merging.
Additional Locations (1)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Jira Link
https://consensyssoftware.atlassian.net/browse/EMBED-226
Description
oauthInitiatedandoauthFailedin the login flow.recordIdis persisted intoargs.customStatebefore session creation, preventing a secondrecordIdfrom being generated aftergetRedirectResult().recordIdandauthConnectionthrough to Torus key retrieval so the same audit context is preserved through completion.callCitadelAuditApi()helper to send audit events to the Citadel endpoint.recordIdreuse.How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Note
Medium Risk
Adds new external audit API calls during login flows and propagates a new
recordIdthrough redirect and share-retrieval paths, which could affect login reliability if the audit endpoint or new params behave unexpectedly.Overview
Adds Citadel auditing to
CustomAuth.triggerLoginby generating/reusing arecordIdand sending best-effortPUT /v1/user/auditevents foroauthInitiated(on first login start) andoauthFailed(on login error).Propagates
recordIdandauthConnectionintogetTorusKey/torus.retrieveShares, introducescallCitadelAuditApihelper, and extends unit tests to verify recordId persistence across redirect round-trips and audit calls.Also switches
@toruslabs/torus.jsto a local tarball dependency and updates.gitignoreto include.npmrc.Written by Cursor Bugbot for commit 63109a6. This will update automatically on new commits. Configure here.