Fix CommandGroup commands_ options not accessible from subcommands#102
Merged
Fix CommandGroup commands_ options not accessible from subcommands#102
Conversation
The commands_ wrapper's options (e.g. --sdk-dir) were never registered in the parser, help generator, or completion engine when dispatching to subcommands. This caused "No option named" errors at runtime. Register commands_ options alongside the CommandGroup in all four places: parser, completion, text help global options, and JSON help global options. Also fix indentation of Options/Rest sections in CommandGroup help output so content is indented under the title, matching the Commands section style.
Member
Author
|
TBR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commands_ wrapper's options (e.g. --sdk-dir) were never registered in the parser, help generator, or completion engine when dispatching to subcommands. This caused "No option named" errors at runtime.
Register commands_ options alongside the CommandGroup in all four places: parser, completion, text help global options, and JSON help global options.
Also fix indentation of Options/Rest sections in CommandGroup help output so content is indented under the title, matching the Commands section style.