Add JSON Marshal/Unmarshal to setof#443
Open
klauspost wants to merge 2 commits into
Open
Conversation
Each type not also support JSON serializers so sets are stored as JSON. Sorted/Unsorted also applies here. Mildly breaking. Open for suggestions.
philhofer
reviewed
May 12, 2026
| i++ | ||
| } | ||
| } else { | ||
| for i < len(data) && data[i] != ',' && data[i] != ']' && |
Member
There was a problem hiding this comment.
I think you only ever use this function to parse numbers and strings, so maybe it's not a huge deal, but obviously this fails in rather pernicious ways if you have a sub-array or sub-structure here.
Member
There was a problem hiding this comment.
(I really wish the Go team would officially release the encoding/json/v2 API because it has a public API for the lexer we could use... oh well.)
Collaborator
Author
There was a problem hiding this comment.
I think it is scheduled for v1.27, but haven't followed too closely.
But yeah, made it specifically for the cases we cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each type not also support JSON serializers so sets are stored as JSON. Sorted/Unsorted also applies here.
Mildly breaking. Open for alternatives.