Remove stale r_renderMode and dead non-PBR shader init#228
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
- Drop r_renderMode cvar (never read; modes 1/2 were placeholders) - Remove unreachable #else branch in vk_shader_modules.c (USE_VK_PBR always on) - Align docs with r_forwardPlus default 1; extend compat check Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags removed
r_renderModetr_init.cbut never read anywhere in the codebase. Values 1 (deferred) and 2 (Forward+) were documented placeholders with no implementation. Forward+ is controlled byr_forwardPlus(default 1).#elseinvk_shader_modules.cUSE_VK_PBRis unconditionally#defined insrc/renderers/vulkan/tr_local.hfor all Vulkan builds, so the legacy manual shader-module init path was unreachable dead code.Documentation
r_forwardPlusdefault 0 or referencedr_renderMode(RENDERERS, ARCHITECTURE, QUICKSTART, RENDERER_2026_ARCHITECTURE_PASS, VULKAN_FBO_AUDIT, TODO_TRIAGE).### Removed.Behavioral parity checks
./scripts/compile_engine.sh vulkan— pass (Vulkan renderer links cleanly)../scripts/q3_openarena_compat_check.sh— new checks pass:r_renderModeabsent,r_forwardPlusdefault 1; pre-existing failures (no release binaries in CI snapshot,cs_autoInit) unchanged.Not changed (candidates / blockers)
r_firstPersonFovEnabled/r_firstPersonScaleEnabled:0still disables FOV/scale override while keeping numeric cvars — intentional compat.cl_*Enabledgameframe toggles,g_ecsMotion: valid runtime off switches for demo/debug.r_pbrvs compile-timeUSE_VK_PBR: runtime disable still supported.USE_VULKAN_RTX: CMake option remains OFF by default; RT path not production-complete.