test: guard native module loading regressions#227
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_native_module_regressionsto guard native VM call argument handling and pk3-backed native library extraction/cache invariants.tests/README.md.Risky behavior now covered
VM_Callzero-fills omittedvmMainargs before copying varargs and passes three stable native slots.vm/native_cache/, cache-reused only after length/CRC validation, and tried before loose filesystem paths.Test files added/updated
tests/scripts/test_native_module_regressions.shCMakeLists.txttests/README.mdWhy this reduces regression risk
This path affects native game/cgame/ui module startup and full-conversion compatibility. The guards pin security- and compatibility-sensitive behavior that is hard to exercise in headless CI, especially pk3 extraction/cache ordering and native vararg handling.
Validation
tests/scripts/test_native_module_regressions.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_native_module_regressions --output-on-failure