3945_arm_cca_v5_s1: Bug fixes for ArmVirtKvmtool guest firmware#12375
Merged
mergify[bot] merged 2 commits intotianocore:masterfrom Apr 3, 2026
Merged
3945_arm_cca_v5_s1: Bug fixes for ArmVirtKvmtool guest firmware#12375mergify[bot] merged 2 commits intotianocore:masterfrom
mergify[bot] merged 2 commits intotianocore:masterfrom
Conversation
tianocore-assign-reviewers
Bot
requested review from
ardbiesheuvel,
kraxel,
leiflindholm and
pierregondois
This was referenced Apr 1, 2026
pierregondois
approved these changes
Apr 2, 2026
ardbiesheuvel
approved these changes
Apr 2, 2026
Merge Queue Status
This pull request spent 11 minutes 24 seconds in the queue, with no time running CI. Required conditions to merge
ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
Contributor
Author
|
@Mergifyio queue |
Merge Queue Status🛑 Queue command has been cancelled |
Contributor
Author
|
@Mergifyio queue |
☑️ Command
|
When the Kvmtool guest is launched without ITS support i.e. when --irq-chip=gicv3-its option is not specified or if --irq-chip=gicv3 is specified, the guest VM does not have an ITS. In such scenarios the guest firmware must not install the IORT table. Therefore, add checks to see if ITS is present before installing the IORT ACPI table. Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <leif.lindholm@oss.qualcomm.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Some guests (e.g. kvmtool) do not provide a SMMU, so the PCI node in the DTB lacks an 'iommu-map'. The current code ASSERTs during boot with: "ASSERT [ConfigurationManagerDxe] RootComplexParser.c(244): (Data != ((void *) 0)) && ((DataSize % (4 * sizeof (UINT32))) == 0)" Instead, return EFI_NOT_FOUND when 'iommu-map' is absent so firmware boot can proceed. Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Leif Lindholm <leif.lindholm@oss.qualcomm.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
samimujawar
force-pushed
the
3945_arm_cca_v5_s1
branch
from
231e173 to
c5f2049
Compare
Merge Queue Status
This pull request spent 51 minutes 53 seconds in the queue, including 1 second running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes for ArmVirtKvmtool guest firmware
This patch series fixes the following issues observed with ArmVirtKvmtool guest firmware:
Note: This is a PR series that includes patches from PR #12224
How This Was Tested
Tested by launching a guest using Kvmtool VMM and booting the ArmVirtKvmtool guest firmware.
Integration Instructions
N/A