UefiCpuPkg/MpLib: Demote print level for "5-Level Paging ="#12321
UefiCpuPkg/MpLib: Demote print level for "5-Level Paging ="#12321mergify[bot] merged 2 commits intotianocore:masterfrom
Conversation
tianocore-assign-reviewers
Bot
requested review from
LiuZhiguang001,
arunsbaskaran,
ecuevasf,
jiaxinwu,
kraxel,
lzeng14,
niruiyu and
td36
|
This debug message is printed only when APs are waken up through INIT-SIPI-SIPI. |
|
Merge #11840, then use DEBUG_PAGING for this message? |
|
I am not sure if this will prevent it completely, when DEBUG_PAGING is set wouldn't the message get printed multple times. My suggestion is to move the log to |
|
Yes, the switch to DEBUG_PAGING will not prevent the message being printed multiple times. I think there is some value in having APs print this too, to show that propagating this from BSP to APs worked properly. Having the BSP + one AP print that message would be enough, not sure there is an easy way to implement that though. |
Moving to that file does not help in all cases. |
It is good to me, but as @kraxel noted if paging is needed to be printed each for BSP and AP, then we are missing a log for AP paging mode. We just need another place to print paging mode for AP, then it will good to go. |
The code being changed is to print the LA57 bit in BSP just when it propagates the bit to APs. |
The "5-Level Paging" debug message in FillExchangeInfoData() is printed every time APs are woken up. At DEBUG_INFO level, this creates unnecessary log noise during normal boot. Change the print level from DEBUG_INFO to DEBUG_PAGING so the message is only visible when paging-related debug logging is enabled. Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
abdattar
force-pushed
the
UefiCpuPkg_verbose
branch
from
bd8eac9 to
a0dc6d4
Compare
|
Changed the macro to "DEBUG_PAGING", Please let me know your thoughts. |
Merge Queue Status
This pull request spent 24 minutes 48 seconds in the queue, including 24 minutes 37 seconds running CI. Required conditions to merge
|
4 participants
The "5-Level Paging" debug message in FillExchangeInfoData() is printed every time APs are woken up. At DEBUG_INFO level, this creates unnecessary log noise during normal boot. Demote the print level from DEBUG_INFO to DEBUG_VERBOSE so the message is only visible when verbose logging is enabled.
How This Was Tested
Tested on AMD platform.
Integration Instructions
N/A