UnitTestFrameworkPkg : Align C++ std version#12318
Draft
GeorgeLiao012 wants to merge 1 commit intotianocore:masterfrom
Draft
UnitTestFrameworkPkg : Align C++ std version#12318GeorgeLiao012 wants to merge 1 commit intotianocore:masterfrom
GeorgeLiao012 wants to merge 1 commit intotianocore:masterfrom
Conversation
tianocore-assign-reviewers
Bot
requested review from
makubacki,
mdkinney and
spbrogan
The C++ standard language standard version should be align in the UnitTestFrameworkPkg, that ensure each compiler to follow same C++ standard to generate unit test app. Signed-off-by: George Liao <george.liao@intel.com>
GeorgeLiao012
force-pushed
the
Align_UT_std_version
branch
from
84e867d to
4da7fce
Compare
|
PR can not be merged due to conflict. Please rebase and resubmit |
makubacki
approved these changes
Mar 24, 2026
Member
|
The change itself is fine to me, but if there is any documentation or rationale for the different versions previously used, this commit message would be a great place to include that information. |
Member
|
I agree more details need to be added on why the current c++ spec levels were set. Some downstream unit test are seeing some build issues with this change. Recommend moving this into a draft PR for now. May require an update to the latest release of googletest (1.17.0) as well to resolve issues. |
Contributor
Author
|
As Mike mentioned I encountered some downstream unit test build issues with c++ std 20, I will address those build issues first. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The C++ standard version doesn't align in the current UnitTestFrameworkPkg, that may caused C++ compiler flow cannot be aligned. it may caused potential issue.
How This Was Tested
None
Integration Instructions
Ensure each compiler adopt same C++ language standard version.