CryptoPkg: Add digest-based RSA-PSS sign and verify APIs#12302
CryptoPkg: Add digest-based RSA-PSS sign and verify APIs#12302mergify[bot] merged 2 commits intotianocore:masterfrom
Conversation
github-actions
Bot
added
the
impact:testing
baranee
force-pushed
the
add-rsa-pss-verify-digest
branch
2 times, most recently
from
0250408 to
8bd6036
Compare
|
Also need to update PcdCryptoServiceFamilyEnable.h to add new API. |
My current thought is that the existing RsaPss.Services.Sign and RsaPss.Services.Verify could still cover both the message (current APIs) and digest (new SignDigest/VerifyDigest) variants. I didn’t realize we expect a 1:1 mapping between every public API and a distinct PCD bit. That said, I’m open to enhancing PcdCryptoServiceFamilyEnable.h as needed. |
baranee
force-pushed
the
add-rsa-pss-verify-digest
branch
2 times, most recently
from
f179d1c to
8fc2598
Compare
baranee
changed the title
Question: If the existing API can support current Digest Variant, then why we need a new specific API for VerifyDigest? |
I’ve clarified that the Sign and Verify bits in PcdCryptoServiceFamilyEnable.h cover both message‑ and digest‑level variants (capabilities, not API names). Per feedback, I added explicit RsaPss.Services.SignDigest and RsaPss.Services.VerifyDigest bits in the latest commit. |
baranee
force-pushed
the
add-rsa-pss-verify-digest
branch
2 times, most recently
from
105ce67 to
e8b10ca
Compare
Add RsaPssSignDigest() and RsaPssVerifyDigest() to BaseCryptLib for signing/verifying precomputed digests. Provide OpenSSL/MbedTLS/Null implementations, expose via EDKII_CRYPTO_PROTOCOL (v24), and add PCD controls for independent service enabling. Include unit tests. Signed-off-by: Anbazhagan Baraneedharan <anbazhagan@hp.com>
baranee
force-pushed
the
add-rsa-pss-verify-digest
branch
from
e8b10ca to
22f1413
Compare
|
@jyao1 Let me know any other concern needs to be addressed for this PR? |
Merge Queue Status
This pull request spent 1 hour 21 minutes 40 seconds in the queue, including 1 hour 21 minutes 26 seconds running CI. Required conditions to merge
|
2 participants
Description
Add RsaPssSignDigest() and RsaPssVerifyDigest() to BaseCryptLib for signing/verifying precomputed digests.
Provide OpenSSL/MbedTLS/Null implementations, expose via EDKII_CRYPTO_PROTOCOL (v24), and
add PCD controls for independent service enabling.
Include unit tests.
How This Was Tested
Verified by invoking the new API with OpenSSL(SMM) and MbedTLS(PEI) implementations
Integration Instructions
N/A