use portable-atomic & exclude alloc::sync::Arc where it is not available#71
Open
stepkun wants to merge 1 commit into
Open
use portable-atomic & exclude alloc::sync::Arc where it is not available#71stepkun wants to merge 1 commit into
stepkun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the conditional compilations to exclude the implementations for 'alloc::sync::Arc' for embedded targets where this Arc is not available (e.g. thumbv6m-none-eabi & riscv32imac-unknown-none-elf)
I also changed to use the crate 'portable-atomic' for atomics, which allows to use 'arcstr' in hopefully all the embedded platforms supported by embassy.
I tested the compile for all the targets and verified proper execution on old pi pico and some other MCU's.
Closes #70