dev -> main#2393
Merged
Merged
Conversation
Setting up GitHub CI for packages
Pin github ci version
* update node version for all packages * update
* fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon
* fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb
* chore: git action to push to main + docs * lint
* chore: fix footer size/colors * remove push to prod action
* chore: upgrade WalletConnect dependencies * chore: upgrade version * bump version --------- Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com>
* Migrate to @metamask/connect-evm Swap out the legacy @metamask/sdk for the new @metamask/connect-evm client and update package metadata (version bump to 2.3.0). Code changes load connect-evm (handling ESM/CJS shapes), reuse a single client instance, attach a disconnect shim to the provider, and map legacy MetaMask SDK options to the new connect-evm option shape (including Infura/custom RPC merging via getInfuraRpcUrls). README updated to reflect the Connect EVM integration and backwards compatibility notes; package.json dependency updated accordingly. * metamask: add chain RPC fallback & options Bump @web3-onboard/metamask to v2.4.0 and enhance SDK initialization. - Add a fallback Mainnet RPC and ensure api.supportedNetworks is always non-empty by deriving RPCs in priority order: Infura, readonlyRPCMap, web3-onboard chains, then public fallback. - Accept and normalize web3-onboard chains (toHexChainId + chainsToRpcMap) and thread them into getInterface/mapLegacyOptions so the client can use configured chains. - Improve dynamic import caching with retry semantics to avoid permanently failing on transient import errors. - Add showInstallModal option (defaults to false) and update legacy options handling (extensionOnly only maps to preferExtension when true; headless preserved). - Minor README formatting and example tweaks. * metamask: forward icon URL & normalize RPC keys Handle dapp icon metadata more safely and normalize readonly RPC keys. Forward http(s) icon URLs to @metamask/connect-evm instead of always base64-encoding app icons (only pass base64Icon when explicitly provided) to avoid overflowing QR/deeplink payloads. Added isHttpUrl and icon selection logic so raw SVG strings are dropped and a fallback URL may be used. Introduced normalizeReadonlyRPCMap to convert readonlyRPCMap keys to hex and ignore invalid IDs, and merged the normalized readonly RPCs after chain-derived RPCs (priority: Infura → chains → readonlyRPCMap → fallback). Documented showInstallModal and clarified extensionOnly behavior in the README, and bumped @metamask/connect-evm to ^1.3.1 in package.json. * ver
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.