chore: fix footer size/colors#2379
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe footer component was updated to revise copyright and license text, combine them into a single div, and update branding references. Visual styles were changed, including background color, icon link colors, and sizing. A new style for the logo link was added. No changes were made to the component's structure or exported entities. Changes
Estimated code review effort1 (~2 minutes) 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/src/lib/components/Footer.svelte (2)
45-46: Consider moving inline style to CSS class for better maintainability.While the functionality is correct, the inline
style="max-height: 20px;"could be moved to the.logo-linkCSS class for better separation of concerns.- <img src={PoweredByTw} alt="Powered by thirdweb" style="max-height: 20px;" /> + <img src={PoweredByTw} alt="Powered by thirdweb" />And update the CSS:
a.logo-link { opacity: 0.8; + max-height: 20px; }
90-95: Logo link opacity styling looks good.The opacity transition provides appropriate visual feedback. If you decide to move the inline
max-heightstyle to CSS (as suggested earlier), consider targeting the img element within the logo-link for the height constraint.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/src/lib/components/Footer.svelte(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Checks
🔇 Additional comments (4)
docs/src/lib/components/Footer.svelte (4)
13-14: LGTM! Text updates are consistent and appropriate.The copyright year update to 2025 and rebranding from Blocknative to thirdweb align with the PR objectives. The punctuation consistency (removing periods) is a good touch.
52-52: Good consolidation of license and copyright text.Combining the license and copyright into a single div simplifies the markup while maintaining readability.
72-73: Verify color contrast compliance with the new light background.The background color change from dark to light grey and reduced height align with the PR objectives. Ensure the dark icon colors (#242835 region text and rgba(20,20,20) icons) provide sufficient contrast against the new light background (#ebebed).
79-79: Icon styling updates are consistent with the light theme.The dark icon colors and reduced hover scale work well with the new light background. The opacity transition (0.8 → 1.0) provides appropriate visual feedback.
Also applies to: 83-84
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb * chore: git action to push to main + docs (#2378) * chore: git action to push to main + docs * lint * chore: fix footer size/colors (#2379) * chore: fix footer size/colors * remove push to prod action * chore: remove blocknative links from header (#2381) * chore: upgrade WalletConnect dependencies (#2385) * chore: upgrade WalletConnect dependencies * chore: upgrade version * bump version --------- Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: Phillip Ho <arcoraven@gmail.com> Co-authored-by: Derek <alexanderderekrein@gmail.com>
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb * chore: git action to push to main + docs (#2378) * chore: git action to push to main + docs * lint * chore: fix footer size/colors (#2379) * chore: fix footer size/colors * remove push to prod action * chore: remove blocknative links from header (#2381) * chore: upgrade WalletConnect dependencies (#2385) * chore: upgrade WalletConnect dependencies * chore: upgrade version * bump version --------- Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> * Migrate to @metamask/connect-evm (#2390) * Migrate to @metamask/connect-evm Swap out the legacy @metamask/sdk for the new @metamask/connect-evm client and update package metadata (version bump to 2.3.0). Code changes load connect-evm (handling ESM/CJS shapes), reuse a single client instance, attach a disconnect shim to the provider, and map legacy MetaMask SDK options to the new connect-evm option shape (including Infura/custom RPC merging via getInfuraRpcUrls). README updated to reflect the Connect EVM integration and backwards compatibility notes; package.json dependency updated accordingly. * metamask: add chain RPC fallback & options Bump @web3-onboard/metamask to v2.4.0 and enhance SDK initialization. - Add a fallback Mainnet RPC and ensure api.supportedNetworks is always non-empty by deriving RPCs in priority order: Infura, readonlyRPCMap, web3-onboard chains, then public fallback. - Accept and normalize web3-onboard chains (toHexChainId + chainsToRpcMap) and thread them into getInterface/mapLegacyOptions so the client can use configured chains. - Improve dynamic import caching with retry semantics to avoid permanently failing on transient import errors. - Add showInstallModal option (defaults to false) and update legacy options handling (extensionOnly only maps to preferExtension when true; headless preserved). - Minor README formatting and example tweaks. * metamask: forward icon URL & normalize RPC keys Handle dapp icon metadata more safely and normalize readonly RPC keys. Forward http(s) icon URLs to @metamask/connect-evm instead of always base64-encoding app icons (only pass base64Icon when explicitly provided) to avoid overflowing QR/deeplink payloads. Added isHttpUrl and icon selection logic so raw SVG strings are dropped and a fallback URL may be used. Introduced normalizeReadonlyRPCMap to convert readonlyRPCMap keys to hex and ignore invalid IDs, and merged the normalized readonly RPCs after chain-derived RPCs (priority: Infura → chains → readonlyRPCMap → fallback). Documented showInstallModal and clarified extensionOnly behavior in the README, and bumped @metamask/connect-evm to ^1.3.1 in package.json. * ver --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: Phillip Ho <arcoraven@gmail.com> Co-authored-by: Derek <alexanderderekrein@gmail.com>
Summary by CodeRabbit
Style
Documentation