Merged
Conversation
React Native's built-in URL constructor does not robustly handle custom schemes like shattermobile://, causing the deep-link callback URL to fail to parse and login to silently fail. Switch to Linking.parse from expo-linking, which is purpose-built for custom-scheme URLs and is already a project dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URLconstructor does not robustly handle custom URL schemes (e.g.shattermobile://), causingnew URL(result.url)in the LinkedIn OAuth helper to fail and login to silently break in the built appLinking.parsefromexpo-linking, which is purpose-built for custom-scheme URLs and is already a project dependencyTest plan
Linking.parseextracts the auth code → exchange + userFetch complete → app lands on JoinEventPage authenticatedeas build --platform ios${FRONTEND_URL}/auth/callback?code=...and completes